Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monologue mode #99

Open
jackmcbarn opened this issue Sep 6, 2020 · 6 comments
Open

Monologue mode #99

jackmcbarn opened this issue Sep 6, 2020 · 6 comments

Comments

@jackmcbarn
Copy link
Collaborator

Ren'Py supports monologue mode now: https://www.renpy.org/doc/html/dialogue.html#monologue-mode

We currently don't, so any uses of it will be turned into a bunch of individual say statements instead, which results in line numbers being wrong.

@CensoredUsername
Copy link
Owner

And it even comes along with the new "rpy monologue" statement which is actually a parser-only directive to just make things a bit more annoying.

This one's going to be jolly. Do all resulting say statements have their lineinfo set to the same line?

@jackmcbarn
Copy link
Collaborator Author

Yep. Although it doesn't all turn into say statements. It can also add an nvl clear user statement that way: https://www.renpy.org/doc/html/text.html#text-tag-clear

I do have an idea for this though.

@CensoredUsername
Copy link
Owner

The addition of rpy monologue none causes several additional complications. we'll likely have to scan all Say statement in the file, and see if any of those would normally trigger monologue mode, and if we detect that, explicitly disable it.

@madeddy
Copy link
Contributor

madeddy commented Dec 28, 2024

Sry to bother about this, but could it be the code for this has already been completed? In #175 it was checked of the list and mentioned in one post from you.

I tried to find the code for it but had no success. Maybe I just don't recognize the right places.

@CensoredUsername
Copy link
Owner

Nothing's been done here. If it's used, line numbers can be wrong.

@madeddy
Copy link
Contributor

madeddy commented Dec 29, 2024

Ah ok, thanks. Something to remember for the time being in case i encounter strange behavior.

Edit: Now i understand. 175#comment states "monologue" was "checked of" because it has already this separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants