Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework container index CI. #529

Open
4 tasks
mohammedzee1000 opened this issue Mar 20, 2018 · 2 comments
Open
4 tasks

Rework container index CI. #529

mohammedzee1000 opened this issue Mar 20, 2018 · 2 comments

Comments

@mohammedzee1000
Copy link
Collaborator

mohammedzee1000 commented Mar 20, 2018

The index ci will need a rework to allow two phase runs (one phase to validate core parameters, and another, to validate stuff, based on condition).

Based on this, i will refactor the CI as follows:

  • Break up each check into a separate function.
  • Re-write index CI engine to run checks, based off a list of checks to run.
  • Update invocation of index CI engine with core checks before index pr merge.
  • Add another CI invocation step to index CI to check changes that update pre-build, to run specific validations, only for subset of changes, for prebuild containers.
@cdrage
Copy link
Contributor

cdrage commented Mar 20, 2018

👍 for being able to run CI without needing CentOS DevCloud

@dharmit
Copy link
Collaborator

dharmit commented Mar 23, 2018

@cdrage I'm assuming you meant CentOS CI (ci.centos.org). Unit testing is something we can surely do without ci.c.o but integration and functional tests are best left to a CI system IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants