-
Notifications
You must be signed in to change notification settings - Fork 50
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nodePort service type support for mizar network provider #429
Comments
I wanted to add this below parameter in grpc file to establish communication between arktos and Mizar for node port service :-For reference I have node port service YMAL file. |
IF we were to add additional messages in grpc, we will have to make changes in files listed below: However, I would suggest we by-pass arktos first. We can add this feature in stand-a-lone mizar for now. (Deployment is managed by kind-setup.sh file). If we by-pass arktos, there is no need to change grpc. @click2cloud-akshay Detailed design discussion is needed after @h-w-chen is back from vacation since he is in charge of this task. The deployment steps are:
|
@click2cloud-akshay this feature seems to involves multiple components in mizar system; not trivial. If you can come up with KEP-like proposal, that would help community to provide feedback; see KEP for its explanation. However, you can use other form of proposal if appropriate too. The proposal you had given, is about prpc format extension in the attempt of accommodating NodePort type service. Not very clear which component (API contract) this grpc extension will apply for. Also, what other components should be extended? It is legitimate to design and implement incrementally; however, it is better to have a overall (rough design level) breakdown which serves as roadmap to the full feature. If you can give a design (online) session, that would be even better. |
This is a sub task of #420.
implements full support of mizar network provider for nodePort type of Kubernetes service
When such a nodePort service is created, mizar should allocate the specific port on EVERY node to which the network communication leads to one pod of the service .
Creation:
Deletion:
The text was updated successfully, but these errors were encountered: