-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] tab links on statististical* consulting page don't work #722
Comments
Hey @csoderberg @aprilcs @jolene-esposito: can one of you help with a fix for this? Thanks! |
I think it's going to be a bigger fix than we anticipate since it has something to do with the tabs. The quickest fix right now is to just unlink them and let people navigate the page using just the tabs. |
I am happy to help in anyway I can, but the tabs were working on the staged version Courtney made, so I don't have the expertise to know why they don't work live. If Jolene's suggestion works in the meantime, let's do that to start. |
I took a quick peek, and I think the paths to the JS at the bottom of the mako file are wrong. I'll submit a quick PR. |
PR: #723 This will fix the 404s, which might fix this issue. |
If the above PR doesn't fix it, then I think I know what the problem is. For the links, I put the url for each tab, but instead I should have used something like this: Statistical Consulting so that the page automatically switches to the tab, rather than having to refresh the page to get it to move to the new tab, which is what is happening now. |
Thanks for looking into this Fitz! I looked, but couldn't find the problem. But, I also don't know that much about the codebase. haha. |
Issue
Go to https://cos.io/stats_consulting/. Give the page a few seconds to load all of its assets. Click on "Statistical and Methodological Consulting" under the "We offer free" header.
I'd expect to be taken to the Statistical Consulting tab, but nothing happens. Clicking directly on the tab works as expected.
Symptoms
When loading the page with an anchor, two assets don't load:
The text was updated successfully, but these errors were encountered: