bug: split sql wrongly like INSERT INTO timestamp VALUES ('1900-1-1 00;00;00');

[discord9]

Describe this problem

Current version of sqlness parse sql wrongly and will split this sql into three separate ones:

INSERT INTO timestamp VALUES ('1900-1-1 00;00;00');

This is due to this place simply split sql by ; instead of checking it semantic meaning:

sqlness/sqlness/src/case.rs

Line 157 in 5469532

for sql in sql.split(QUERY_DELIMITER) {

// An intercetor may generate multiple SQLs, so we need to split them.
        for sql in sql.split(QUERY_DELIMITER) {

Steps to reproduce

CREATE TABLE timestamp(t TIMESTAMP time index);

INSERT INTO timestamp VALUES ('1900-1-1 00;00;00');

will make sqlness think the last sql is three sql:

INSERT INTO timestamp VALUES ('1900-1-1 00;
00;
00');

Expected behavior

not splitting sql

Additional Information

No response

[waynexia]

Looks like this regression was introduced in #63 cc @jiacai2050

We need to make a new release after this is fixed. Maybe 0.6.1? If we don't class #67 as a breaking change.

[jiacai2050]

Why you use ; in time string, shouldn't it be :?

[discord9]

Why you use ; in time string, shouldn't it be :?

It's a test for parsing incorrect timestamp, so many corner cases for handling timestamp are covered

[jiacai2050]

Got it.

I already submit a PR fix this, will make a release today.

[jiacai2050]

Here it is.

• https://github.com/CeresDB/sqlness/releases/tag/v0.6.1
• https://crates.io/crates/sqlness/0.6.1

[waynexia]

Thank you @jiacai2050 👍