-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider auto-generating the structure
classes
#20
Comments
First versions of the BatchTable/FeatureTable/Style classes have been integrated via #36 . I'll still leave this issue open for a moment, because the state of wetzel that generated these classes is not perfect: It was still necessary to manually add some |
Trying to fix the |
The
structure
directory contains very basic structures for the handling of 3D Tiles data. These classes are plain old objects, without any functionality (i.e. no functions - only plain properties). These classes had been created manually in the 3d-tiles-validator, and then moved into the 3d-tiles-tools for the 0.2.0 release.The structure of these classes directly corresponds to the 3D Tiles specification JSON schema. Therefore, it would probably make sense to replace these classes by classes that are auto-generated from the schema. The benefits here would be to
Of course, quick websearches show that there are tools for that, e.g. https://www.npmjs.com/package/json-schema-to-typescript - but ... further tests may be necessary before tackling this - for example, this library links to "json-schema-04", and we'll need one that supports much more recent schema versions.
The text was updated successfully, but these errors were encountered: