New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GetParameterValue functions #92

Open

r-veenstra opened this issue Nov 12, 2024 · 0 comments

Contributor

r-veenstra commented Nov 12, 2024

There are at least three functions that do similar logic, and should probably be consolidated.

GetParameterValue in GltfExportContext.cs
GetParameterValue in IonExportUtils.cs
GetParameterValueAsString in RevitMaterials.cs

Each throws out slightly different defaults which could create edge cases depending on how the code handles the defaults.

r-veenstra mentioned this issue

Connect and upload to Cesium ion #71

Merged

corybarr mentioned this issue

Handle materials with the same name #127

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment