Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack peer dependency #3

Open
ksrb opened this issue Aug 15, 2018 · 4 comments
Open

Update webpack peer dependency #3

ksrb opened this issue Aug 15, 2018 · 4 comments

Comments

@ksrb
Copy link

ksrb commented Aug 15, 2018

Any chance the webpack peer dependency could be update to at least 2.0.0 - 3.10.0.

I've been using the cesium-react in webpack 3 without issue for a couple of weeks now following the guide in the blog (https://cesium.com/blog/2018/03/05/integrating-cesium-and-react/).
Having some trouble in webpack 4 but once those are resolved maybe even setting the peer dependency to >=2.0.0 would be okay.

I could make a PR if necessary.

@ksrb ksrb changed the title Update peer webpack dependency Update webpack peer dependency Aug 15, 2018
@LHolst
Copy link

LHolst commented Sep 6, 2018

I am having the same issue

└── UNMET PEER DEPENDENCY [email protected]

npm ERR! peer dep missing: webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc, required by [email protected]
npm ERR! peer dep missing: webpack@^2.0.0, required by [email protected]

@rmckeel
Copy link

rmckeel commented Apr 9, 2020

I would also like to see this >=2.0.0. I'm running it without problems on 4.41.2 (as part of [email protected]).

@jony89
Copy link

jony89 commented Nov 8, 2020

I was just about to post this issue as well.

This becomes crucial with npm7

ERR! Could not resolve dependency:
npm ERR! peer webpack@"^2.0.0" from [email protected]
npm ERR! node_modules/strip-pragma-loader
npm ERR!   dev strip-pragma-loader@"1.0.0" from firstresponse@undefined
npm ERR!   apps/first-react

@ggetz

@serut
Copy link
Contributor

serut commented Jul 20, 2021

I've check this plugin with the last version of Webpack and it's working well (5.45.1)
image

Before -------------  
[....]
function viewerPerformanceWatchdogMixin(viewer, options) {
  //>>includeStart('debug', pragmas.debug);
  if (!defined(viewer)) {
    throw new DeveloperError("viewer is required.");
  }
  //>>includeEnd('debug');
  options = defaultValue(options, defaultValue.EMPTY_OBJECT);

After -------------  
[...]
function viewerPerformanceWatchdogMixin(viewer, options) {
  options = defaultValue(options, defaultValue.EMPTY_OBJECT);

serut added a commit to serut/strip-pragma-loader that referenced this issue Jul 20, 2021
ggetz added a commit that referenced this issue Jun 15, 2022
Fix peerDependencies - #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants