Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing Flask-User #4

Closed
PaluMacil opened this issue Jun 29, 2016 · 2 comments
Closed

Consider replacing Flask-User #4

PaluMacil opened this issue Jun 29, 2016 · 2 comments

Comments

@PaluMacil
Copy link
Contributor

Flask-User pulls in Pycrypto somewhat unnecessarily since Flask hash functions (werkzeug.security.generate_password_hash()) use PBKDF2 by default since May 2013 anyway. Eliminating this would simplify the pip install process--especially for Windows where binary wheels aren't provided for this. Additionally, I'm not sure Flask User is necessary. You can add a simple wrapper like Miguel Grinberg did in https://github.com/miguelgrinberg/flasky/blob/master/app/decorators.py

That's not to say that Flask-User is useless, but it is more than we need. On the plus side, it gives a lot of additional decorators, but it hasn't recently accepted any pull requests to fix deprecated .ext. imports, so that is concerning as well.

@juzten
Copy link
Contributor

juzten commented Jun 29, 2016

I am using Flask User for a hand full of features that we will need: registration, login/logout, roles, password management, registration emails, some of the decorators, etc..

This should keep the user management system where we don't have to do much. I've looked at Flask-User issues and it seems there is a pull request to fix the ext imports updates and hopefully it'll be merged soon as the latest activity on it was a day or 2 ago.

I'm opening an issue related to getting setup with vagrant to keep install issues a minimum. see #6

@PaluMacil
Copy link
Contributor Author

Alrighty. Sounds good. I just wanted to gather opinions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants