Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filecoin.StateMinerProvingDeadline #4630

Closed
LesnyRumcajs opened this issue Aug 8, 2024 · 3 comments · Fixed by #4635
Closed

Fix Filecoin.StateMinerProvingDeadline #4630

LesnyRumcajs opened this issue Aug 8, 2024 · 3 comments · Fixed by #4635
Assignees

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Aug 8, 2024

Issue summary

The method failed in CI:

 Request dump: Request { method_name: "Filecoin.StateMinerProvingDeadline", params: Array [String("f028064"), Array [Object {"/": String("bafy2bzacear4yvorlyo62zz2a4wvnnrblabracw5cpsuv3jcriuvdhoc7u7l6")}, Object {"/": String("bafy2bzaceay4zbpxfoe534ioax6e7ldx2chbjwaddmlnbq4j2czckb37f767c")}, Object {"/": String("bafy2bzacecueldmjxtt43s3nxaxqff7q44buliq3eexivs5mk2sg3pxaagfry")}, Object {"/": String("bafy2bzacec4dolq35sxz7qoon4svwy6tfiaqmt5tvldkduousqjcdbvvxoyfw")}]], result_type: PhantomData<serde_json::value::Value>, api_paths: V0, timeout: 120s }
  Request params JSON: ["f028064",[{"/":"bafy2bzacear4yvorlyo62zz2a4wvnnrblabracw5cpsuv3jcriuvdhoc7u7l6"},{"/":"bafy2bzaceay4zbpxfoe534ioax6e7ldx2chbjwaddmlnbq4j2czckb37f767c"},{"/":"bafy2bzacecueldmjxtt43s3nxaxqff7q44buliq3eexivs5mk2sg3pxaagfry"},{"/":"bafy2bzacec4dolq35sxz7qoon4svwy6tfiaqmt5tvldkduousqjcdbvvxoyfw"}]]
  Forest response: {
    "Challenge": 1859682,
    "Close": 1859762,
    "CurrentEpoch": 1859702,
    "FaultCutoff": 1859632,
    "FaultDeclarationCutoff": 70,
    "Index": 18,
    "Open": 1859702,
    "PeriodStart": 1858622,
    "WPoStChallengeLookback": 20,
    "WPoStChallengeWindow": 60,
    "WPoStPeriodDeadlines": 48,
    "WPoStProvingPeriod": 2880
  }
  Lotus response: {
    "Challenge": 1862502,
    "Close": 1862582,
    "CurrentEpoch": 1859702,
    "FaultCutoff": 1862452,
    "FaultDeclarationCutoff": 70,
    "Index": 17,
    "Open": 1862522,
    "PeriodStart": 1861502,
    "WPoStChallengeLookback": 20,
    "WPoStChallengeWindow": 60,
    "WPoStPeriodDeadlines": 48,
    "WPoStProvingPeriod": 2880
  }
  Diff:  {
  
  -  "Challenge": 1859682,
  
  -  "Close": 1859762,
  
  +  "Challenge": 1862502,
  
  +  "Close": 1862582,
  
     "CurrentEpoch": 1859702,
  
  -  "FaultCutoff": 1859632,
  
  +  "FaultCutoff": 1862452,
  
     "FaultDeclarationCutoff": 70,
  
  -  "Index": 18,
  
  -  "Open": 1859702,
  
  -  "PeriodStart": 1858622,
  
  +  "Index": 17,
  
  +  "Open": 1862522,
  
  +  "PeriodStart": 1861502,
  
     "WPoStChallengeLookback": 20,
  
     "WPoStChallengeWindow": 60,
  
     "WPoStPeriodDeadlines": 48,
  
     "WPoStProvingPeriod": 2880
  
   }

in https://github.com/ChainSafe/forest/actions/runs/10302364092/job/28516154550

Snapshot is forest_snapshot_calibnet_2024-08-08_height_1859736.forest.car.zst, persisted in the DO debug bucket here

Other information and links

@lemmih
Copy link
Contributor

lemmih commented Aug 9, 2024

The issue is reproducible.

We're missing some logic in updating the proving dateline if it has elapsed, but that is not the source of this failure. I'll keep investigating.

@lemmih
Copy link
Contributor

lemmih commented Aug 9, 2024

Ah, it is because we're missing that logic.

@lemmih
Copy link
Contributor

lemmih commented Aug 9, 2024

Requires an update to fil-actor-states: ChainSafe/fil-actor-states#322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants