Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope GHA runs to relevant changes #4721

Open
ansermino opened this issue Sep 2, 2024 · 1 comment
Open

Scope GHA runs to relevant changes #4721

ansermino opened this issue Sep 2, 2024 · 1 comment
Labels
Type: Task Discrete task to implement

Comments

@ansermino
Copy link
Member

Issue summary

Presently a number of checks run on EVERY pull request. These could be scoped to relevant code changes to reduce the consumption of runner minutes.

This example removes a GHA check and does not modify any files:
Screenshot 2024-09-02 at 11 33 23 AM

Some of these could be scoped to changes to any Rust code files, or in the case of documentation the relevant directory.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#using-filters-to-target-specific-paths-for-pull-request-or-push-events

Other information and links

@LesnyRumcajs
Copy link
Member

I agree some of those can be better filtered, though I'd like to emphasize that one needs to be careful there.

Rust workflows depend on non-Rust elements - Makefiles, artefacts in the repository, even Go files, shell scripts et cetera. At one point, they even depended on markdown files (I believe someone was checking if the README files can be served by a fake server or something like this). We need to check if this is not the case anymore, otherwise a deletion of such files might trigger failure of consecutive PRs.

@ansermino ansermino added the Type: Task Discrete task to implement label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task Discrete task to implement
Projects
Status: No status
Development

No branches or pull requests

2 participants