Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix F3 sidecar FFI build for aarch64 on MacOS #4777

Closed
hanabi1224 opened this issue Sep 19, 2024 · 1 comment · Fixed by #4809
Closed

Fix F3 sidecar FFI build for aarch64 on MacOS #4777

hanabi1224 opened this issue Sep 19, 2024 · 1 comment · Fixed by #4809
Assignees

Comments

@hanabi1224
Copy link
Contributor

And re-enable Go FFI build for aarch64 on MacOS. As follow up of #4764

fn is_sidecar_ffi_enabled() -> bool {
    // Note: arm64 is disabled for now as cross-compilation is not yet supported in rust2go
    // and it's reported rust2go build does not work on arm64 MacOS
    if cfg!(target_arch = "x86_64") {
        // Opt-out building the F3 sidecar staticlib
        match std::env::var("FOREST_F3_SIDECAR_FFI_BUILD_OPT_OUT") {
            Ok(value) => !matches!(value.to_lowercase().as_str(), "1" | "true"),
            _ => true,
        }
    } else {
        false
    }
}
@ruseinov
Copy link
Contributor

Taking this on after talking to @elmattic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants