Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Flaky Filecoin.EthGetTransactionReceipt and Filecoin.EthGetTransactionReceiptLimited tests #4996

Open
hanabi1224 opened this issue Nov 25, 2024 · 6 comments · May be fixed by #5205
Open
Assignees
Labels
Type: Bug Something isn't working

Comments

@hanabi1224
Copy link
Contributor

hanabi1224 commented Nov 25, 2024

Describe the bug

CI failure: https://github.com/ChainSafe/forest/actions/runs/12003774159/job/33457955568?pr=4986

To reproduce

  1. Go to '...'
  2. Run '....'
  3. See error

Log output

Log Output
paste log output...

Expected behaviour

Screenshots

Environment (please complete the following information):

  • OS:
  • Branch/commit
  • Hardware

Other information and links

@hanabi1224 hanabi1224 added the Type: Bug Something isn't working label Nov 25, 2024
@hanabi1224 hanabi1224 changed the title [RPC] Flacky Filecoin.EthGetTransactionReceipt and Filecoin.EthGetTransactionReceiptLimited tests [RPC] Flaky Filecoin.EthGetTransactionReceipt and Filecoin.EthGetTransactionReceiptLimited tests Nov 25, 2024
@elmattic
Copy link
Contributor

Hopefully the next RC of Lotus will fix that🤞

#4983 (comment)

@LesnyRumcajs
Copy link
Member

@elmattic Do you know if it fixed the issue?

@elmattic
Copy link
Contributor

I don't know. Will need to investigate.

@LesnyRumcajs LesnyRumcajs moved this from New to Ready in Forest Backlog 🌲 Jan 16, 2025
@elmattic elmattic self-assigned this Jan 23, 2025
@elmattic
Copy link
Contributor

@LesnyRumcajs might be fixed by #5176 so assigning me the issue, just in case.

@elmattic elmattic moved this from Ready to In progress in Forest Backlog 🌲 Jan 23, 2025
@elmattic
Copy link
Contributor

elmattic commented Jan 29, 2025

It's almost good now. Still some missing logs in our case:

lotus:
{
  "id": 1,
  "jsonrpc": "2.0",
  "result": {
    "transactionHash": "0x44a43e13ccc967f6fde892ac6c6591c58cac59295024640006231f14a13b0f0c",
    "transactionIndex": "0x0",
    "blockHash": "0xf442f59c2ae12b6629f325b783c262b44fe6e5cd6d81f823120c5c7406c400cd",
    "blockNumber": "0x240754",
    "from": "0x229e8da5f0a1528b2d62cb7c5bf6f6c64365272c",
    "to": "0xacc0a0cf13571d30b4b8637996f5d6d774d4fd62",
    "root": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "status": "0x1",
    "contractAddress": null,
    "cumulativeGasUsed": "0x0",
    "gasUsed": "0xdac403",
    "effectiveGasPrice": "0x3d719",
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000020000000100000000000020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000400000000000080400000000000000000000000000800000000000000000000000000000000000000000000000",
    "logs": [
      {
        "address": "0xacc0a0cf13571d30b4b8637996f5d6d774d4fd62",
        "data": "0x000000000000000000000000000000000000000000000000181f30aef6fbfddc00000000000000000000000000000000000000000000158eee0f60c8acca7200",
        "topics": [
          "0xe24720f45cb74f2d55f1deebb6098f50f10b511dab8a7d47c4819a08dcd0b895",
          "0x7404e3d104ea7841c3d9e6fd20adfe99b4ad586bc08d8f3bd3afef894cf184de"
        ],
        "removed": false,
        "logIndex": "0x0",
        "transactionIndex": "0x0",
        "transactionHash": "0x44a43e13ccc967f6fde892ac6c6591c58cac59295024640006231f14a13b0f0c",
        "blockHash": "0xf442f59c2ae12b6629f325b783c262b44fe6e5cd6d81f823120c5c7406c400cd",
        "blockNumber": "0x240754"
      }
    ],
    "type": "0x2"
  }
}


forest:
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "transactionHash": "0x44a43e13ccc967f6fde892ac6c6591c58cac59295024640006231f14a13b0f0c",
    "transactionIndex": "0x0",
    "blockHash": "0xf442f59c2ae12b6629f325b783c262b44fe6e5cd6d81f823120c5c7406c400cd",
    "blockNumber": "0x240754",
    "from": "0x229e8da5f0a1528b2d62cb7c5bf6f6c64365272c",
    "to": "0xacc0a0cf13571d30b4b8637996f5d6d774d4fd62",
    "root": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "status": "0x1",
    "contractAddress": null,
    "cumulativeGasUsed": "0x0",
    "gasUsed": "0xdac403",
    "effectiveGasPrice": "0x3d719",
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "logs": [],
    "type": "0x2"
  }
}

Likely a corner case we haven't handled well. Investigating!

@elmattic
Copy link
Contributor

elmattic commented Jan 30, 2025

When searching for this eth tx, Forest's StateManager::search_for_message finds a tipset at epoch 2361173.

Later, this leads to recomputing events using this tipset, which contains no messages, ultimately resulting in no eth logs as well.

@elmattic elmattic linked a pull request Jan 30, 2025 that will close this issue
4 tasks
@elmattic elmattic moved this from In progress to In review in Forest Backlog 🌲 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

3 participants