Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): handle non-existing actors gracefully in F3 power proportion CLI #5173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(cli): handle non-existing actors gracefully in F3 power proportion CLI #5173

wants to merge 3 commits into from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 22, 2025 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

➜  lotus git:(master) ✗ lotus f3 pt gp 1179 1167 8888
{
  "Instance": 126141,
  "FromEC": false,
  "PowerTable": {
    "CID": "bafy2bzaced7pp3jghq3hdgaayl3uxcofhuedq6wwqm3pyer3oiywvqofobfto",
    "ScaledTotal": 65524
  },
  "ScaledSum": 12,
  "Proportion": 0.0001831390025028997,
  "NotFound": [
    8888
  ]
}

➜  forest git:(hm/f3-power-proportion-non-existing-actors) forest-cli f3 pt gp 1179 1167 8888
{
  "Instance": 126141,
  "FromEC": false,
  "PowerTable": {
    "CID": "bafy2bzaced7pp3jghq3hdgaayl3uxcofhuedq6wwqm3pyer3oiywvqofobfto",
    "ScaledTotal": 65524
  },
  "ScaledSum": 12,
  "Proportion": 0.0001831390025028997,
  "NotFound": [
    8888
  ]
}

Reference issue to close (if applicable)

Closes #5174

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title fix(cli): handle non-existing actors gracefully in F3 power proportio… fix(cli): handle non-existing actors gracefully in F3 power proportion CLI Jan 22, 2025
@hanabi1224 hanabi1224 marked this pull request as ready for review January 22, 2025 11:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 22, 2025 11:54
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and elmattic and removed request for a team January 22, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle non-existing actors gracefully in F3 power proportion CLI
2 participants
@hanabi1224 @LesnyRumcajs