Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using snappy along with snappyjs #4170

Open
twoeths opened this issue Jun 17, 2022 · 2 comments · May be fixed by #6483
Open

Consider using snappy along with snappyjs #4170

twoeths opened this issue Jun 17, 2022 · 2 comments · May be fixed by #6483
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jun 17, 2022

Is your feature request related to a problem? Please describe.

Right now we only use snappyjs and it's good with current gossip message size, but after the merge the block size is way bigger and it's better to use "snappy" at least for beacon_block topic, it also support async version

Uncompressed size Times of attestation size # of runs per second - snappyjs # of runs per second - snappy
229 bytes 1 815 120
22.9 kb 100 2022 2047
114 kb 500 3.6 8.6

Describe the solution you'd like

Consider using snappy for beacon_block topic and snappyjs for other topics
@dapplion dapplion added the scope-performance Performance issue and ideas to improve performance. label Jun 21, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Jun 22, 2022

another direction is to research if we can port the snappyjs implementation into assembly script since the interface is similar to as-sha256

@twoeths twoeths mentioned this issue Jun 23, 2022
Closed
@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Jul 13, 2022
@philknows
Copy link
Member

Reevaluate snappy locations based on current block sizes.

@twoeths twoeths mentioned this issue Nov 11, 2023
Open
@twoeths twoeths linked a pull request Jul 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use snappy-wasm ChainSafe/lodestar
3 participants
@twoeths @dapplion @philknows