perf(reqresp): improve the reqresp request/response methods #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6801 +/- ##
============================================
- Coverage 61.87% 61.87% -0.01%
============================================
Files 562 561 -1
Lines 59331 59335 +4
Branches 1915 1918 +3
============================================
+ Hits 36714 36715 +1
- Misses 22574 22577 +3
Partials 43 43 |
wemeetagain
reviewed
May 22, 2024
| export async function sendResponse( | ||
| peerId: PeerId, | ||
| protocolID: string, | ||
| { |
There was a problem hiding this comment.
why did this function signature go from f({a, b, c, d, e}) to f(a, b, {c, modules: {d, e}})
There was a problem hiding this comment.
To make it consistent for request and response methods. Now both functions sendResponse and sendRequest have same function signature with similar options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid conditional parameters inside most frequently used methods.
Description
sendRequestis used and that includes 4 conditions with??on timeout values. These can be avoided.handleRequestis now renamed assendResponseto make it aligned with counter part function.handleRequestwas extra conditions for timeout values that can be avoided.Steps to test or reproduce