Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread (chat discussion) deletion dialog title is not localized #1551

Open
petri opened this issue Nov 28, 2024 · 2 comments · May be fixed by #1616
Open

Thread (chat discussion) deletion dialog title is not localized #1551

petri opened this issue Nov 28, 2024 · 2 comments · May be fixed by #1616
Labels
frontend Pertains to the frontend.

Comments

@petri
Copy link

petri commented Nov 28, 2024

frontend/src/components/organisms/sidebar/threadHistory/DeleteThreadButton.tsx has other strings localized but "Delete Thread?" is not.
@dosubot dosubot bot added the frontend Pertains to the frontend. label Nov 28, 2024
@dokterbob
Copy link
Collaborator

Thanks for spotting this @petri! Happy to accept PR with the missing string.

petri added a commit to koodaamo/chainlit that referenced this issue Dec 30, 2024
@petri
localize thread deletion title -> fix Chainlit#1551
9502146
@petri petri linked a pull request Dec 30, 2024 that will close this issue
Open
@petri
Copy link
Author

petri commented Dec 30, 2024

Thanks for spotting this @petri! Happy to accept PR with the missing string.

@dokterbob there you go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Pertains to the frontend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

localize thread deletion title -> fix Chainlit/chainlit#1551 koodaamo/chainlit
2 participants
@dokterbob @petri