fix: duplicate postcode suggested

Using utility utilArrayUniqBy provided in the iD codebase to fix the duplication issue.

Author: ChaitanyaKadu03

modules/ui/fields/address.js

@@ -24,16 +24,16 @@ export function uiFieldAddress(field, context) {
             ['housenumber', 'street'],
             ['city', 'postcode']
         ]
-      }];
+    }];
 
     fileFetcher.get('address_formats')
-        .then(function(d) {
+        .then(function (d) {
             _addressFormats = d;
             if (!_selection.empty()) {
                 _selection.call(address);
             }
         })
-        .catch(function() { /* ignore */ });
+        .catch(function () { /* ignore */ });
 
 
     function getNear(isAddressable, type, searchRadius, resultProp) {
@@ -70,7 +70,7 @@ export function uiFieldAddress(field, context) {
                     klass: `address-${type}`
                 };
             })
-            .sort(function(a, b) {
+            .sort(function (a, b) {
                 return a.dist - b.dist;
             });
 
@@ -114,9 +114,10 @@ export function uiFieldAddress(field, context) {
     }
 
     function getNearPostcodes() {
-        return [... new Set([]
+        const postcodes = []
             .concat(getNearValues('postcode'))
-            .concat(getNear(d => d.tags.postal_code, 'postcode', 200, 'postal_code')))];
+            .concat(getNear(d => d.tags.postal_code, 'postcode', 200, 'postal_code'));
+        return utilArrayUniqBy(postcodes, item => item.value);
     }
 
     function getNearValues(key) {
@@ -152,17 +153,17 @@ export function uiFieldAddress(field, context) {
         ];
 
         var widths = addressFormat.widths || {
-            housenumber: 1/5, unit: 1/5, street: 1/2, place: 1/2,
-            city: 2/3, state: 1/4, postcode: 1/3
+            housenumber: 1 / 5, unit: 1 / 5, street: 1 / 2, place: 1 / 2,
+            city: 2 / 3, state: 1 / 4, postcode: 1 / 3
         };
 
         function row(r) {
             // Normalize widths.
-            var total = r.reduce(function(sum, key) {
+            var total = r.reduce(function (sum, key) {
                 return sum + (widths[key] || 0.5);
             }, 0);
 
-            return r.map(function(key) {
+            return r.map(function (key) {
                 return {
                     id: key,
                     width: (widths[key] || 0.5) / total
@@ -171,7 +172,7 @@ export function uiFieldAddress(field, context) {
         }
 
         var rows = _wrap.selectAll('.addr-row')
-            .data(addressFormat.format, function(d) {
+            .data(addressFormat.format, function (d) {
                 return d.toString();
             });
 
@@ -201,23 +202,23 @@ export function uiFieldAddress(field, context) {
             switch (d.id) {
                 case 'street':
                     nearValues = getNearStreets;
-                break;
+                    break;
                 case 'place':
                     nearValues = getNearPlaces;
-                break;
+                    break;
                 case 'street+place':
                     nearValues = () => []
                         .concat(getNearStreets())
                         .concat(getNearPlaces());
                     d.isAutoStreetPlace = true;
                     d.id = _tags[`${field.key}:place`] ? 'place' : 'street';
-                break;
+                    break;
                 case 'city':
                     nearValues = getNearCities;
-                break;
+                    break;
                 case 'postcode':
                     nearValues = getNearPostcodes;
-                break;
+                    break;
                 default:
                     nearValues = getNearValues;
             }
@@ -226,12 +227,12 @@ export function uiFieldAddress(field, context) {
                 .call(uiCombobox(context, `address-${d.isAutoStreetPlace ? 'street-place' : d.id}`)
                     .minItems(1)
                     .caseSensitive(true)
-                    .fetcher(function(typedValue, callback) {
+                    .fetcher(function (typedValue, callback) {
                         typedValue = typedValue.toLowerCase();
                         callback(nearValues(d.id)
                             .filter(v => v.value.toLowerCase().indexOf(typedValue) !== -1));
                     })
-                    .on('accept', function(selected) {
+                    .on('accept', function (selected) {
                         if (d.isAutoStreetPlace) {
                             // set subtag depending on selected entry
                             d.id = selected ? selected.type : 'street';
@@ -283,7 +284,7 @@ export function uiFieldAddress(field, context) {
 
 
     function change(onInput) {
-        return function() {
+        return function () {
             var tags = {};
 
             _wrap.selectAll('input')
@@ -316,7 +317,7 @@ export function uiFieldAddress(field, context) {
 
 
     function updatePlaceholder(inputSelection) {
-        return inputSelection.attr('placeholder', function(subfield) {
+        return inputSelection.attr('placeholder', function (subfield) {
             if (_tags && Array.isArray(_tags[field.key + ':' + subfield.id])) {
                 return t('inspector.multiple_values');
             }
@@ -339,28 +340,28 @@ export function uiFieldAddress(field, context) {
 
     function updateTags(tags) {
         utilGetSetValue(_wrap.selectAll('input'), subfield => {
-                var val;
-                if (subfield.isAutoStreetPlace) {
-                    const streetKey = `${field.key}:street`;
-                    const placeKey = `${field.key}:place`;
-
-                    if (tags[streetKey] !== undefined || tags[placeKey] === undefined) {
-                        val = tags[streetKey];
-                        subfield.id = 'street';
-                    } else {
-                        val = tags[placeKey];
-                        subfield.id = 'place';
-                    }
+            var val;
+            if (subfield.isAutoStreetPlace) {
+                const streetKey = `${field.key}:street`;
+                const placeKey = `${field.key}:place`;
+
+                if (tags[streetKey] !== undefined || tags[placeKey] === undefined) {
+                    val = tags[streetKey];
+                    subfield.id = 'street';
                 } else {
-                    val = tags[`${field.key}:${subfield.id}`];
+                    val = tags[placeKey];
+                    subfield.id = 'place';
                 }
-                return typeof val === 'string' ? val : '';
-            })
-            .attr('title', function(subfield) {
+            } else {
+                val = tags[`${field.key}:${subfield.id}`];
+            }
+            return typeof val === 'string' ? val : '';
+        })
+            .attr('title', function (subfield) {
                 var val = tags[field.key + ':' + subfield.id];
                 return (val && Array.isArray(val)) ? val.filter(Boolean).join('\n') : undefined;
             })
-            .classed('mixed', function(subfield) {
+            .classed('mixed', function (subfield) {
                 return Array.isArray(tags[field.key + ':' + subfield.id]);
             })
             .call(updatePlaceholder);
@@ -372,20 +373,20 @@ export function uiFieldAddress(field, context) {
     }
 
 
-    address.entityIDs = function(val) {
+    address.entityIDs = function (val) {
         if (!arguments.length) return _entityIDs;
         _entityIDs = val;
         return address;
     };
 
 
-    address.tags = function(tags) {
+    address.tags = function (tags) {
         _tags = tags;
         updateTags(tags);
     };
 
 
-    address.focus = function() {
+    address.focus = function () {
         var node = _wrap.selectAll('input').node();
         if (node) node.focus();
     };