Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovered hosts does not include "active" #82

Open
msherman64 opened this issue Nov 4, 2022 · 2 comments
Open

Recovered hosts does not include "active" #82

msherman64 opened this issue Nov 4, 2022 · 2 comments

Comments

@msherman64
Copy link

and n.provision_state in ['available']]

Hosts only recover when "available", but "active" seems to be a permissable state

@msherman64
Copy link
Author

If a node fails to provision, and then succeeds on a second attempt, the following happens:

  1. node moves to provision state “deploy failed”
  2. blazar sets node to unhealthy
  3. hammer moves node from “deploy failed” -> “available”
  4. User runs deploy again, node moves through provision states:
    a. “deploying”
    b. “wait-call-back”
    c. “active”

@Mark-Powers
Copy link

from Mike:

node should be reservable if:

  • node is in stable, healthy state, e.g. available, active
  • or transition state FROM above healthy state, e.g. available -> deploying , active -> deleting, etc

and not reservable if it’s in an unhealthy state, or transition from one
but we can probably use the target_provision_state field to make it more robust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants