Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ACIS gain map #2

Open
hamogu opened this issue Jan 16, 2015 · 1 comment
Open

Implement ACIS gain map #2

hamogu opened this issue Jan 16, 2015 · 1 comment
Milestone

Comments

@hamogu
Copy link
Member

hamogu commented Jan 16, 2015

Currently, MARX uses the FEF simplification for the ACIS gain, not the full gain map, because that is several orders of magnitude faster. I should investigate, if the full gain could be supported as an option for simulations that need to be as close as possible and where runtime is not a concern.

There might be already some hooks in place:
from marx-feat.h:

/* One or the other of these may be defined, but not both. */
#define MARX_HAS_ACIS_GAIN_MAP          0
#define MARX_HAS_ACIS_FEF               1
@hamogu hamogu added this to the future milestone Dec 3, 2015
@hamogu
Copy link
Member Author

hamogu commented Dec 28, 2015

It's actually implemented (just grep for "MARX_HAS_ACIS_GAIN_MAP"); but I'm not sure that implementation is complete and correct. Need to test and then maybe make a switch so that the user can select between FEF and GAIN MAP at run-time instead of me selecting it at release time by hard-coding in marx-feat.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant