Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.erb files should be checked during CI build #679

Open
makyen opened this issue Sep 14, 2019 · 1 comment · May be fixed by #749
Open

.erb files should be checked during CI build #679

makyen opened this issue Sep 14, 2019 · 1 comment · May be fixed by #749

Comments

@makyen
Copy link
Contributor

makyen commented Sep 14, 2019

Currently, the .erb files are not checked during CI testing. On a couple of occasions, I've run into simple syntax errors in .erb files which could have/should have been caught.

Unfortunately, the RuboCop maintainers feel that testing .erb files is out of scope for RuboCop. However, there's a gem called Ruumba, which will strip the code out of .erb files and feed it to rubocop.

We should look into using Ruumba, or some other method of automatically checking our .erb files during CI.
thesecretmaster added a commit that referenced this issue Jul 8, 2020
@thesecretmaster
Started work on #679, saw 300+ errors, stopped
9138f0c
@thesecretmaster thesecretmaster linked a pull request Jul 8, 2020 that will close this issue
Add ruumba for checking ERB files #749
Draft
@thesecretmaster
Copy link
Member

erb-lint may be a better tool for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ruumba for checking ERB files Charcoal-SE/metasmoke
2 participants
@makyen @thesecretmaster