Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player UI considerations #139

Open
galenriley opened this issue Jun 29, 2020 · 2 comments
Open

Player UI considerations #139

galenriley opened this issue Jun 29, 2020 · 2 comments
Assignees

Comments

@galenriley
Copy link
Member

Current version doesn't crash any more, but it's a wonky pattern.

At minimum, need to implement a PlayerView component and SinglePlayer screen to match Song pattern

But also, the whole Roster/Player/Song or Roster/TwitterList interaction is weird and the backbutton behavior is not sensible, so let's think about the whole thing.

@galenriley galenriley self-assigned this Jun 29, 2020
@galenriley
Copy link
Member Author

but like also the whole thing needs to be revisited, what with player image galleries and so on

@galenriley
Copy link
Member Author

oh hey also there's a buncha calls like
this.props.navigation.setOptions({ header: null });
all over the place that don't cause harm to exist but do nothing (because the behavior we want is set in the navigator setup currently, and the way to do it in the screen is different) so delete all of those when addressing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant