Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline mode #35

Open
galenriley opened this issue Nov 8, 2019 · 3 comments
Open

Offline mode #35

galenriley opened this issue Nov 8, 2019 · 3 comments
Assignees
@tacoman @galenriley
Labels
app

Comments

@galenriley
Copy link
Member

No description provided.

@galenriley galenriley added the app label Nov 8, 2019
@galenriley
Copy link
Member Author

Add some sort of indicator across the UI when we could not hit the server and may not have the latest data. Something like a no connection banner

@tacoman tacoman changed the title Figure out where persistent storage makes sense and implemented appropriately using a well considered pattern Offline mode Sep 1, 2021
@tacoman
Copy link
Member

tacoman commented Sep 1, 2021

This can reasonably be implemented per-area, e.g. roster, songbook, feed, etc. On any successful load, we can store the returned JSON in persistent storage. Any attempt to load data should try the network first, and if that fails return the stored data. The result should also include a property indicating whether the data came from online or offline, and control the presence of the banner accordingly.

@galenriley
Copy link
Member Author

Agreed. I'd like to see this alongside a pull-down-to-refresh gesture on the roster screen and songbook ToC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tacoman tacoman

@galenriley galenriley

Labels
app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tacoman @galenriley