-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions Deploy Script is very long #13
Comments
We discussed this in the PR that added the miner page, and decided to go for build time fetching for multiple reasons:
We were concerned about build times but didn't see them as an issue. Can you please explain where they are? |
Build time has gone from 1 min to 11 mins in the actions tab since we deployed this. I dont know if it will affect our plan in the short term. |
Ah are you concerned about growing the bill? |
If that's the case, I'd say let's fix it once it becomes an issue. And I would rather pay a bit for GitHub Actions than to make a more complex solution, that is potentially slower and more brittle for end users |
Currently, we are building a static page for each miner. This means the build script is taking a very long time. I think instead, we should make the miner page dynamic. I.e. we fetch the data from the APIs in the page itself rather than at build time.
We should keep the home page as static build time content.
The text was updated successfully, but these errors were encountered: