Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions Deploy Script is very long #13

Open
patrickwoodhead opened this issue Dec 13, 2024 · 4 comments
Open

GH Actions Deploy Script is very long #13

patrickwoodhead opened this issue Dec 13, 2024 · 4 comments

Comments

@patrickwoodhead
Copy link
Contributor

Currently, we are building a static page for each miner. This means the build script is taking a very long time. I think instead, we should make the miner page dynamic. I.e. we fetch the data from the APIs in the page itself rather than at build time.

We should keep the home page as static build time content.

@juliangruber
Copy link
Member

We discussed this in the PR that added the miner page, and decided to go for build time fetching for multiple reasons:

  • It's simpler
  • No CORS support is required
  • It's more performant

We were concerned about build times but didn't see them as an issue. Can you please explain where they are?

@patrickwoodhead
Copy link
Contributor Author

Build time has gone from 1 min to 11 mins in the actions tab since we deployed this. I dont know if it will affect our plan in the short term.

@juliangruber
Copy link
Member

Ah are you concerned about growing the bill?

@juliangruber
Copy link
Member

juliangruber commented Dec 13, 2024

If that's the case, I'd say let's fix it once it becomes an issue. And I would rather pay a bit for GitHub Actions than to make a more complex solution, that is potentially slower and more brittle for end users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants