Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Lookup Modules 'site' and 'sites'. #658

Merged
merged 12 commits into from
Oct 9, 2024
Merged

Created Lookup Modules 'site' and 'sites'. #658

merged 12 commits into from
Oct 9, 2024

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Sep 11, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There were no lookup modules to query

  • the sites of a distributed environment
  • a particular site of a distributed environment

What is the new behavior?

  • Now there are.

Other information

This PR can be merged before the "site module" PR.

@lgetwan lgetwan marked this pull request as draft September 11, 2024 13:15
@lgetwan
Copy link
Contributor Author

lgetwan commented Sep 13, 2024

Sorry for the mess of commits. I currently can't test locally, due to "Wifi on ICE" ;-)

@lgetwan lgetwan added lookup:site This affects the lookup module 'site'. enhancement New feature or request labels Sep 13, 2024
@lgetwan lgetwan self-assigned this Sep 13, 2024
@lgetwan lgetwan marked this pull request as ready for review September 13, 2024 14:51
@robin-checkmk
Copy link
Member

Sorry for the mess of commits. I currently can't test locally, due to "Wifi on ICE" ;-)

We can just squash the commits on this one, as they do not carry too much relevance as it is a new feature. :)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 24, 2024
robin-checkmk
robin-checkmk approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@robin-checkmk robin-checkmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me function-wise. Pending a code review, this is good to merge.

@robin-checkmk robin-checkmk added the release:5.3.0 Affects the mentioned release. label Sep 24, 2024
@robin-checkmk robin-checkmk mentioned this pull request Sep 30, 2024
Merged
7 tasks
@robin-checkmk robin-checkmk merged commit ce7e844 into devel Oct 9, 2024
37 checks passed
@robin-checkmk robin-checkmk deleted the feature/lookup-site branch October 9, 2024 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robin-checkmk robin-checkmk robin-checkmk approved these changes

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk

Assignees

@lgetwan lgetwan

Labels
documentation Improvements or additions to documentation enhancement New feature or request lookup:site This affects the lookup module 'site'. release:5.3.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgetwan @robin-checkmk