Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esx_vsphere_snapshot.py #719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update esx_vsphere_snapshot.py #719

wants to merge 1 commit into from

Conversation

Ma7h1
Copy link
Contributor

@Ma7h1 Ma7h1 commented Jun 21, 2024

reopen
#690

@tgl27
Update esx_vsphere_snapshot.py
b7228e1 
Some ESX server do not include a value for "vm".
@scolakovic
Copy link
Contributor

Hi Ma7h1,

Thank you for the PR.
Can you explain the reasoning behind the change?
As far as I see from the code, there is no case where the 'vm' attribute is None.

Best Regards,
Sofia

@martinhv
Copy link
Member

Background is: Some ESXi servers do not include a value for "vm".

Mathias, could you please share the output for such a server. We might use it for tests then or making this more transparent for the future for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ma7h1 @scolakovic @martinhv @englertor @tgl27