Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffEqSensitivity -> SciMLSensitivity #110

Open
ChrisRackauckas opened this issue Jun 25, 2022 · 6 comments · May be fixed by #111
Open

DiffEqSensitivity -> SciMLSensitivity #110

ChrisRackauckas opened this issue Jun 25, 2022 · 6 comments · May be fixed by #111

Comments

@ChrisRackauckas
Copy link
Contributor

See SciML/SciMLSensitivity.jl#665 . It looks like the interfaces you use are unchanged so it should be a very simple update.

@rkurchin
Copy link
Member

Only getting around to this now 😱 and running into some issues. The error is MethodError: no method matching needs_concrete_A(::Nothing), for more see e.g. CI logs here...any thoughts on how to proceed here?

@rkurchin
Copy link
Member

Ping @DhairyaLGandhi over here, also linking to #111

@rkurchin rkurchin linked a pull request Nov 18, 2022 that will close this issue
@rkurchin rkurchin linked a pull request Nov 18, 2022 that will close this issue
@rkurchin
Copy link
Member

Pinging again, @DhairyaLGandhi and/or @ChrisRackauckas, any insight on the above?

@ChrisRackauckas
Copy link
Contributor Author

Maybe there's an X-Y problem here. What's the reason for even having these libraries? IIRC, it was for a DEQ, but nowadays should you just use the AGNs with https://docs.sciml.ai/DeepEquilibriumNetworks/stable/ ? If you stick an AGN inside of that it should be fine? The simplest thing to do may be to just slim down.

@rkurchin
Copy link
Member

Hopefully I'll actually get around to trying this soon...does this mean that I should convert AGN over to using Lux instead of Flux? Or will DeepEquilibriumNetworks play nice with my Flux-based layers?

@ChrisRackauckas
Copy link
Contributor Author

@avikpal does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants