Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] cancelled memberships still show rights if any previous membership held had them #139

Open
offbyone opened this issue Feb 14, 2022 · 0 comments

Comments

@offbyone
Copy link
Member

Because of the additive way rights are calculated in reservations.rb, if a contact had any order that had rights before the current one without, it'll still retain all the rights of those previous memberships. This is important for cases where a membership loses rights if purchased after a certain point -- we need to ensure that our nomination rights are tied to "when" a membership is acquired -- but when we cancel a membership it retains those rights, which is problematic from a hugo admin PoV.

I'm not entirely sure how to solve this in the current model; subtractive rights are probably a bad idea, but we might need to set up a different way of modeling them to make this work. This won't be just a code hack, it'll need DB modeling work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant