From b85dcaee9fb1960eefdcb39aa90d3e57afd48934 Mon Sep 17 00:00:00 2001 From: jatinchowdhury18 Date: Fri, 18 Nov 2022 19:57:57 -0800 Subject: [PATCH] Attempted fix for #234 (#242) * Attempted fix for #234 * Apply clang-format Co-authored-by: github-actions[bot] --- src/BYOD.cpp | 6 ++---- src/gui/toolbar/presets/PresetsComp.cpp | 2 +- src/gui/toolbar/presets/PresetsSaveDialog.cpp | 2 +- src/gui/utils/ErrorMessageView.cpp | 16 ++++++++-------- src/processors/chain/ChainIOProcessor.cpp | 4 +++- src/processors/chain/ChainIOProcessor.h | 2 ++ 6 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/BYOD.cpp b/src/BYOD.cpp index a91199f2..aa1a2c46 100644 --- a/src/BYOD.cpp +++ b/src/BYOD.cpp @@ -96,15 +96,13 @@ void BYOD::getStateInformation (MemoryBlock& destData) void BYOD::setStateInformation (const void* data, int sizeInBytes) { stateManager->loadState (getXmlFromBinary (data, sizeInBytes).get()); - + if (wrapperType == WrapperType::wrapperType_AudioUnitv3) { // In the AUv3 we need to alert the hsot about parmaeter tree changes // _after_ the host has finished loading the plugin state. Timer::callAfterDelay (500, [this] - { - updateHostDisplay (ChangeDetails{}.withParameterInfoChanged (true)); - }); + { updateHostDisplay (ChangeDetails {}.withParameterInfoChanged (true)); }); } } diff --git a/src/gui/toolbar/presets/PresetsComp.cpp b/src/gui/toolbar/presets/PresetsComp.cpp index ab95fac5..365ab48a 100644 --- a/src/gui/toolbar/presets/PresetsComp.cpp +++ b/src/gui/toolbar/presets/PresetsComp.cpp @@ -193,7 +193,7 @@ int PresetsComp::addBasicPresetOptions (PopupMenu* menu, int optionID) optionID = addPresetMenuItem (menu, optionID, "Delete Preset", - [&, safeParent = SafePointer {getParentComponent() }] + [&, safeParent = SafePointer { getParentComponent() }] { if (auto* currentPreset = manager.getCurrentPreset()) { diff --git a/src/gui/toolbar/presets/PresetsSaveDialog.cpp b/src/gui/toolbar/presets/PresetsSaveDialog.cpp index 4fe85734..d963226c 100644 --- a/src/gui/toolbar/presets/PresetsSaveDialog.cpp +++ b/src/gui/toolbar/presets/PresetsSaveDialog.cpp @@ -1,6 +1,6 @@ #include "PresetsSaveDialog.h" -#include "state/presets/PresetInfoHelpers.h" #include "gui/utils/ErrorMessageView.h" +#include "state/presets/PresetInfoHelpers.h" namespace { diff --git a/src/gui/utils/ErrorMessageView.cpp b/src/gui/utils/ErrorMessageView.cpp index 840bb025..84a2fa2e 100644 --- a/src/gui/utils/ErrorMessageView.cpp +++ b/src/gui/utils/ErrorMessageView.cpp @@ -48,13 +48,13 @@ BYODPluginEditor* findTopLevelEditor (Component* currentComponent) void ErrorMessageView::showErrorMessage (const String& title, const String& message, const String& buttonText, Component* comp) { // similar to: -// NativeMessageBox::showAsync (MessageBoxOptions() -// .withIconType (MessageBoxIconType::WarningIcon) -// .withTitle (title) -// .withMessage (message) -// .withButton (buttonText) -// .withAssociatedComponent (comp), -// nullptr); + // NativeMessageBox::showAsync (MessageBoxOptions() + // .withIconType (MessageBoxIconType::WarningIcon) + // .withTitle (title) + // .withMessage (message) + // .withButton (buttonText) + // .withAssociatedComponent (comp), + // nullptr); if (auto* topLevelEditor = findTopLevelEditor (comp)) { @@ -67,7 +67,7 @@ void ErrorMessageView::showErrorMessage (const String& title, const String& mess bool ErrorMessageView::showYesNoBox (const juce::String& title, const juce::String& message, juce::Component* comp) { // similar to: -// return NativeMessageBox::showYesNoBox (MessageBoxIconType::WarningIcon, title, message, comp) == 1; + // return NativeMessageBox::showYesNoBox (MessageBoxIconType::WarningIcon, title, message, comp) == 1; if (auto* topLevelEditor = findTopLevelEditor (comp)) { diff --git a/src/processors/chain/ChainIOProcessor.cpp b/src/processors/chain/ChainIOProcessor.cpp index 01c0b84c..b0791d06 100644 --- a/src/processors/chain/ChainIOProcessor.cpp +++ b/src/processors/chain/ChainIOProcessor.cpp @@ -112,7 +112,9 @@ dsp::AudioBlock ChainIOProcessor::processAudioInput (const AudioBuffercall ([this] + { latencyChangedCallbackFunc ((int) oversampling.getLatencySamples()); }, + true); } const auto useStereo = processChannelInputs (buffer); diff --git a/src/processors/chain/ChainIOProcessor.h b/src/processors/chain/ChainIOProcessor.h index 91feaaeb..46616c71 100644 --- a/src/processors/chain/ChainIOProcessor.h +++ b/src/processors/chain/ChainIOProcessor.h @@ -45,5 +45,7 @@ class ChainIOProcessor bool isPrepared = false; + chowdsp::SharedDeferredAction mainThreadAction; + JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ChainIOProcessor) };