We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
var actualETag = "\"" + bundle.Hash.ToHexString() + "\""; var givenETag = context.Request.Headers["If-None-Match"]; if(givenETag.Equals(actualETag)) ...
actualETag is a string but givenETag is IEnumerable<string>.
string
IEnumerable<string>
I think it should compare actualETag with context.Request.Headers["If-None-Match"].FirstOrDefault()
actualETag
context.Request.Headers["If-None-Match"].FirstOrDefault()
Current implementation means unchanged resources are returned with 200 when it should be 304.
The text was updated successfully, but these errors were encountered:
I ran into the same bug, came up with the same fix, came to post this same issue.
Sorry, something went wrong.
No branches or pull requests
actualETag is a
string
but givenETag isIEnumerable<string>
.I think it should compare
actualETag
withcontext.Request.Headers["If-None-Match"].FirstOrDefault()
Current implementation means unchanged resources are returned with 200 when it should be 304.
The text was updated successfully, but these errors were encountered: