Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should external shear convergence be zeros? #199

Closed
ConnorStoneAstro opened this issue Mar 21, 2024 · 2 comments
Closed

Should external shear convergence be zeros? #199

ConnorStoneAstro opened this issue Mar 21, 2024 · 2 comments

Comments

@ConnorStoneAstro
Copy link
Member

Currently throws an error
@AlexandreAdam
Copy link
Collaborator

Yes, by definition external convergence is 0. In #196 I define the external convergence to be zero. See also the derivation of the external convergence by Meneghetti.

By construction, the external convergence only produce a shear, so the Jacobian matrix of the lens equation must have zero on its diagonal by construction.

@ConnorStoneAstro
Copy link
Member Author

Solved in #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexandreAdam @ConnorStoneAstro