Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchinterp1d and KeOps are incompatible with vmap #30

Closed
adam-coogan opened this issue Apr 21, 2023 · 1 comment
Closed

torchinterp1d and KeOps are incompatible with vmap #30

adam-coogan opened this issue Apr 21, 2023 · 1 comment

Comments

@adam-coogan
Copy link
Collaborator

vmap is not compatible with torchinterp1d or keops. Both use torch.autograd.Function, which is not compatible with vmap by default. This will be a problem if you want to e.g. vmap over a bunch of NFWs for simulating or computing magnifications, since they may use torchinterp1d via FlatLambdaCDM. This is fixable, but requires modifying torchinterp1d and keops. I've opened issues in both projects' repos.

This isn't really our responsibility to fix, but I wanted to document this since it's good to be aware of this restriction.

@ConnorStoneAstro
Copy link
Member

We no longer depend on torchinterp1d and only have limited compatibility with keops. It would be good to open another issue specifically for keops compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants