Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ensure consistent axis ratio definition #300

Open
ConnorStoneAstro opened this issue Dec 18, 2024 · 1 comment
Open

refactor: ensure consistent axis ratio definition #300

ConnorStoneAstro opened this issue Dec 18, 2024 · 1 comment
Labels
refactor A code change that neither fixes a bug nor adds a feature

Comments

@ConnorStoneAstro
Copy link
Member

Current models that involve ellipticity have a number of definitions for axis ratio q. Currently they include R = \sqrt{q^2x^2 + y^2} for SIE and EPL; and R = \sqrt{x^2 + y^2 / q^2} for Sersic.
@ConnorStoneAstro ConnorStoneAstro added the refactor A code change that neither fixes a bug nor adds a feature label Dec 18, 2024
@ConnorStoneAstro
Copy link
Member Author

Further inspection seems to show that actually all objects are using R = \sqrt{x^2 + y^2 / q^2}. can be closed with a further check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ConnorStoneAstro