Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autograd through NFW deflection angles returns NAN #69

Closed
ConnorStoneAstro opened this issue Aug 14, 2023 · 3 comments
Closed

autograd through NFW deflection angles returns NAN #69

ConnorStoneAstro opened this issue Aug 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ConnorStoneAstro
Copy link
Member

When testing multiplane with NFW lenses, I noticed that I get nans when trying to do autograd through them. This doesn't happen with pseudojaffe or other lenses.
@ConnorStoneAstro ConnorStoneAstro added the bug Something isn't working label Aug 14, 2023
@AlexandreAdam
Copy link
Collaborator

There seem to be some numerical instability going on. If we fix this issue we should fix Issue 45 at the same time.

@ConnorStoneAstro
Copy link
Member Author

After completing the TNFW lens in #74 I believe the issue is that some operations for the NFW need to be done in the complex plane. Once this was added for the TNFW it became more stable and autograd started working

@ConnorStoneAstro
Copy link
Member Author

Closed by #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexandreAdam @ConnorStoneAstro