Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid possible SEGFAULT on DESTROY stage #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid possible SEGFAULT on DESTROY stage #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions R3.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2895,6 +2895,7 @@ match(SV* r3_sv, SV *str_sv)
void DESTROY(SV* r3_sv)
PPCODE:
void* pad = SvRV(SvRV(r3_sv));
if (!pad) return;
int branch_n = *(int*)((char*)pad + sizeof(node*));
SV** target = (SV**)((char*)pad + sizeof(node*) + sizeof(int));
for(int i=0; i<branch_n; ++i)
Expand Down
36 changes: 36 additions & 0 deletions t/destroy.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Before 'make install' is performed this script should be runnable with
# 'make test'. After 'make install' it should work as 'perl Router-R3.t'

#########################

# change 'tests => 1' to 'tests => last_test_to_print';

use strict;
use warnings;

use Test::More tests => 2;
BEGIN { use_ok('Router::R3') };

my %router;

sub _init {
%router = (
POST => Router::R3->new(
'/api/v1/event/create' => sub {},
'/api/v1/account/i/{i_account:\d+}/status' => sub {},
),
GET => Router::R3->new(
'/api/v1/account/i/{i_account:\d+}/status' => sub {},
'/api/v1/account/{id}/status' => sub {},
),
DELETE => Router::R3->new(
'/api/v1/group/i/{i_group:\d+}' => sub {},
'/api/v1/group/{name}' => sub {},
),
);
}

_init();

ok( $router{POST}->match( '/api/v1/event/create' ) );
# ensure that there are no Segmentation Fault on exit