Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't handle http-requests with a list of required metrics #135

Open
willardgibbs opened this issue Apr 24, 2019 · 0 comments
Open

Can't handle http-requests with a list of required metrics #135

willardgibbs opened this issue Apr 24, 2019 · 0 comments
Labels
bug Something isn't working code Concerns code

Comments

@willardgibbs
Copy link
Contributor

willardgibbs commented Apr 24, 2019

When additional metrics (#95) are calculated, necessary for calculating metrics are taken from CollectorRegistry. List of metrics names are passed from the result of the HTTP-query parsing to the filteredMetricFamilySamples method.
There is bug: necessary metrics may not be in the list, and HTTP-response will not be sent. Only necessary for calculations metrics names should be passed in method.

@willardgibbs willardgibbs added bug Something isn't working code Concerns code labels Apr 24, 2019
@willardgibbs willardgibbs added this to the Release 1.0.0. milestone Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code Concerns code
Projects
None yet
Development

No branches or pull requests

1 participant