Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the returned data squema from pathfinder server #172

Closed
llunaCreixent opened this issue Mar 22, 2023 · 1 comment
Closed

Review the returned data squema from pathfinder server #172

llunaCreixent opened this issue Mar 22, 2023 · 1 comment
Assignees
@llunaCreixent

Comments

@llunaCreixent
Copy link
Member

No description provided.

@llunaCreixent llunaCreixent self-assigned this Mar 22, 2023
@llunaCreixent
Copy link
Member Author

The response of the two different APIs is different, as explained here. The differences are:

  • transferSteps.tokenOwnerAddress in cli type, and transferSteps.token_owner in server type
  • from, to, and transferValue are not in the server response, but they are actually not necessary
  • When the returned maxFlowValue is lower than the requested value (like when we ask for a big amount to know the max flow), the steps are returned along with the maxFlowValue. This is different with the circles-api response where no steps where returned.
    @louilinn take this into account for Update circles-core dependency and use new pathfinder service circles-myxogastria#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llunaCreixent llunaCreixent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llunaCreixent