Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gin Fizz and Gimlet have the same mixture. #6264

Closed
YuriDaruski opened this issue Jan 9, 2024 · 0 comments · Fixed by #6394
Closed

Gin Fizz and Gimlet have the same mixture. #6264

YuriDaruski opened this issue Jan 9, 2024 · 0 comments · Fixed by #6394

Comments

@YuriDaruski
Copy link

YuriDaruski commented Jan 9, 2024 •
edited
Loading

Round ID: 2893

Testmerges:

Reproduction:

Attempt to make Gimlet, produce Gin Fizz

Related code:

/datum/chemical_reaction/drinks/gin_fizz
name = "Gin Fizz"
id = "ginfizz"
result = "ginfizz"
required_reagents = list("gin" = 1, "sodawater" = 1, "limejuice" = 1)
result_amount = 3

/datum/chemical_reaction/drinks/gimlet
name = "Gimlet"
id = "gimlet"
result = "gimlet"
required_reagents = list("gin" = 1, "limejuice" = 1, "sodawater" = 1)
result_amount = 3
@iliyaxox iliyaxox mentioned this issue Apr 16, 2024
Merged
timothyteakettle pushed a commit that referenced this issue Apr 16, 2024
@iliyaxox
Fixes gimlet recipe (#6394)
1a8c655 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Gin Fizz and Gimlet had the exact same recipe (`"gin" = 1, "sodawater" =
1, "limejuice" = 1`). Gimlet's recipe now is `"gin" = 1, "limejuice" =
1, "sugar" = 1` because it made sense. And because I saw on the internet
that sugar goes with it. I don't drink. I don't even know what gimlet
is, I just looked it up

![image](https://github.com/Citadel-Station-13/Citadel-Station-13-RP/assets/64568243/767bfede-b089-4f25-852b-0186960f3793)

## Why It's Good For The Game

Fixes #6264 

## Changelog

:cl:
fix: Gimlet can actually be made now, since it doesn't share the same
recipe as Gin Fizz anymore.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes gimlet recipe iliyaxox/Citadel-Station-13-RP
1 participant
@YuriDaruski