Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in term dates cause seat data to crash #186

Open
inghamn opened this issue Jun 22, 2017 · 0 comments
Open

Gaps in term dates cause seat data to crash #186

inghamn opened this issue Jun 22, 2017 · 0 comments
Labels

Comments

@inghamn
Copy link
Member

inghamn commented Jun 22, 2017

Term::getNextTerm fails when there's already a future term in the system, but with a start date that does not line up with the end date of the current term.

Example the current term is 1/1/2015 - 1/4/2017 and the next term after that is 1/7/2017 - 1/14/2019
There's a gap of a few days there. When displaying the seats listing the Term::getNextTerm call will crash.

This is partly because Term::getNextTerm tries to generate the next term if there isn't one. And the fact that it increments by one day past the end date of a term. When it goes to create a new term, there's not enough room in the schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant