Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group meetings by time, instead of just date #310

Open
inghamn opened this issue Feb 1, 2022 · 4 comments
Open

Group meetings by time, instead of just date #310

inghamn opened this issue Feb 1, 2022 · 4 comments
Assignees
Labels
feature Feature Request

Comments

@inghamn
Copy link
Member

inghamn commented Feb 1, 2022

In the data feeds, we group meetings by date. In most cases this is sufficient, however there are a few cases when the same committee meets multiple times in one day. When there are multiple meetings in one day, the data feed does not offer enough information to distinguish the meetings.

@inghamn inghamn added this to the 2.5.3 milestone Feb 1, 2022
@inghamn inghamn self-assigned this Feb 1, 2022
@inghamn
Copy link
Member Author

inghamn commented Feb 1, 2022

This is a requirement for the city website:

City-of-Bloomington/drupal-theme-cob#237

@inghamn
Copy link
Member Author

inghamn commented Feb 1, 2022

It turns out, in the database, we never kept track of the time of the meetings, only the date. This change is going to require a database schema change and data migration.

We'll need to run through all the meetingFiles and get the full datetime information from the Google Calendar Event.

inghamn added a commit that referenced this issue Feb 1, 2022
This adds another level of organization to the meeting data feed.  Meetings are now organized by date and event_id.  Meetings that are not in Google Calendar will have an event_id of zero.  This means if there are multiple meetings on the same day that are not in a calendar, they will still be lumped together.

We do not have time information in the database for meetingFiles.  However, for meetings that are in Google Calendar, we can display the start time of the event.
Ultimately, we need to do a database schema change to change the meetingFiles.date column to be a datetime.  Then we'll need to run through all the Google Calendar events and populate the datetime information.

Until then, the only place we do not have the time information is on the MeetingFiles/Index controller.  That is purely reading from the database.

Updates #310
@inghamn
Copy link
Member Author

inghamn commented Feb 1, 2022

The commit gets us mostly there. It covers all cases except for the MeetingFiles/Index route. That page is reading entirely from the database, and we don't have time information there.

Ultimately, we need to do a database schema change to make the column a datetime and then write a script to populate the datetime from all the Google Calendars.

@inghamn inghamn modified the milestones: 2.5.3, 2.6 - Alternates Nov 4, 2022
@inghamn inghamn modified the milestones: 2.6 - Alternates, 2.6.1 Nov 16, 2022
@inghamn inghamn modified the milestones: 2.6.1, 2.7.1 Jun 27, 2023
@inghamn inghamn added the feature Feature Request label Jan 19, 2024
@inghamn inghamn modified the milestones: 2.7.1, 2.8 Mar 26, 2024
@inghamn
Copy link
Member Author

inghamn commented Sep 19, 2024

This will likely be taken care of if we tackle actually tracking meetings: #363

inghamn added a commit that referenced this issue Oct 11, 2024
Meetings are now coming from the database, rather than directly from Google Calendar.  We'll still need to figure out the best way to keep in sync with Google Calendars.

Updates #363
Updates #310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature Request
Projects
None yet
Development

No branches or pull requests

1 participant