Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP-1543 Date row removal callbacks, updated date_recur modules, updated php to 8.3 #827

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jussiviitamaki
Copy link
Contributor

@jussiviitamaki jussiviitamaki commented Nov 27, 2024

Actions necessary for applying the changes: (for example composer install; drush updb; drush cim)

lando rebuild && lando composer install && lando drush deploy

Testing instructions:

  • Login and edit service
  • Go to "aika- ja paikka" -tab
  • If time and place is empty add new element
  • Add second date row
  • Click "Remove"
  • Confirm correct row is deleted
  • Try to remove the last date row
  • Confirm it just resets

** PHP 8.3 **

  • Add new and edit old services and confirm everything works
  • Confirm search works
  • Confirm node displays work
  • Confirm various listings work
  • Confirm there is no errors in database logs
  • lando test public/modules/custom
  • Test pass

Review checklist:

  • The code conforms to Drupal coding standards
  • I have reviewed the code for security and quality issues
  • I have tested the code with the proper user roles
  • I have moved the ticket to the approval lane, added testing instructions and assigned it to the product owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant