chore: install and init husky and commitlint #300
Conversation
KK-1347. The Git commits should be linted and the code changes should be tested before the commit is committed. - Installed Husky as a pre commit tool. - Installed commitlint as a tool to check the conventional commit format. - Installed lint-staged as a tool to gather the staged git files. Used this as a guide: https://theodorusclarence.com/shorts/husky-commitlint-prettier.
nikomakela
force-pushed
the
KK-1347-precommit-tools
branch
from
ae37317 to
e7d343a
Compare
|
KUKKUU-ADMIN branch is deployed to platta: https://kukkuu-admin-pr300.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-admin-pr300.dev.hel.ninja 😆🎉🎉🎉 |
|
KUKKUU-ADMIN branch is deployed to platta: https://kukkuu-admin-pr300.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-admin-pr300.dev.hel.ninja 😆🎉🎉🎉 |
|
KUKKUU-ADMIN branch is deployed to platta: https://kukkuu-admin-pr300.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-admin-pr300.dev.hel.ninja 😆🎉🎉🎉 |
…commit hook KK-1347
KK-1347
|
KUKKUU-ADMIN branch is deployed to platta: https://kukkuu-admin-pr300.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-admin-pr300.dev.hel.ninja 😆🎉🎉🎉 |
|
Doctoc is verbose by default and can take pages just saying that it didn't find anything to update, but it seems there's no normal way to make it less verbose as there's thlorenz/doctoc#261 |
|
|
KUKKUU-ADMIN branch is deployed to platta: https://kukkuu-admin-pr300.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-admin-pr300.dev.hel.ninja 😆🎉🎉🎉 |
There was a problem hiding this comment.
The changes made by doctoc are left as unstaged changes after the commit has been made, which is not ideal, maybe adding a "Doctoc and how it works"-section or something like that into the README.md and documenting how it works currently would be a transparent way to handle this.
I'll add something about the pre-commit hooks in this #302 and this City-of-Helsinki/kukkuu-ui#632. |
KK-1347.
The Git commits should be linted and the code changes should be tested
before the commit is committed.
format.
Used this as a guide:
https://theodorusclarence.com/shorts/husky-commitlint-prettier.