chore: install and init husky and commitlint #625
Conversation
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr625.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-ui-pr625.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1347-precommit-tools
branch
from
f686551 to
c8a31ac
Compare
KK-1347. The Git commits should be linted and the code changes should be tested before the commit is committed. - Installed Husky as a pre commit tool. - Installed commitlint as a tool to check the conventional commit format. - Installed lint-staged as a tool to gather the staged git files. Used this as a guide: https://theodorusclarence.com/shorts/husky-commitlint-prettier.
KK-1347. Install doctoc as development dependency. Run the doctoc during the pre-commit process.
nikomakela
force-pushed
the
KK-1347-precommit-tools
branch
from
c8a31ac to
80cb248
Compare
KK-1347. Updated the code styling by running `lint-staged`, that runs `yarn format:code` and `yarn format:scss`.
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr625.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-ui-pr625.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1347-precommit-tools
branch
from
481c4b4 to
1a09cfb
Compare
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr625.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-ui-pr625.dev.hel.ninja 😆🎉🎉🎉 |
|
Doctoc is verbose by default and can take pages just saying that it didn't find anything to update, but it seems there's no normal way to make it less verbose as there's thlorenz/doctoc#261 |
|
There was a problem hiding this comment.
The changes made by doctoc are left as unstaged changes after the commit has been made, which is not ideal, maybe adding a "Doctoc and how it works"-section or something like that into the README.md and documenting how it works currently would be a transparent way to handle this.
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr625.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-ui-pr625.dev.hel.ninja 😆🎉🎉🎉 |
I'll add something about the pre-commit hooks in this City-of-Helsinki/kukkuu-admin#302 and this #632. |
KK-1347.
The Git commits should be linted and the code changes should be tested before the commit is committed.
Used this as a guide:
https://theodorusclarence.com/shorts/husky-commitlint-prettier.