Tagged CI builds are failing

[revett]

Problem

Example: https://travis-ci.org/CityOfZion/neo-local/builds/409058230

CI builds on the master branch or a tag should ignore the make check-version check as that should apply to a feature branch.

See:

neo-local/scripts/travis.sh

Lines 1 to 12 in fb455db

	#!/bin/bash
	# Script that Travis CI will run to test the project, it is conditional on the branch.
	set -e
	if [[ $TRAVIS_BRANCH == 'master' ]]
	then
	make integration-tests
	else
	make check-version
	make integration-tests
	fi

[jeroenptrs]

@revett upon research I stumbled upon the fact that $TRAVIS_BRANCH is either empty or contains the tag name on tagged builds, which is why the build runs make check-versions.

References:

• Travis CI issues with tagged releases Didstopia/PDFSharp#34
• https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

Proposal:
Use $TRAVIS_TAG instead

[anthdm]

Hello? Will this be merged soon? Or at least reviewed? @jeroenptrs you can add me as second reviewers to make this pass?