Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agressive fire suppression #111

Open
WildWeazel opened this issue Jul 26, 2015 · 8 comments
Open

Agressive fire suppression #111

WildWeazel opened this issue Jul 26, 2015 · 8 comments

Comments

@WildWeazel
Copy link

https://forum.civcraft.co/t/fire-spread-is-an-unbalanced-bypass-of-citadel/744?u=wildweazel

Berge messed up our revision history so I won't try to merge but here's the diff that did it: a4e12fb

@WildWeazel
Copy link
Author

basically https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/listener/BlockListener.java#L259 and down needs to be uncommented and preferably wrapped in a config option

@ttk2
Copy link

ttk2 commented Jul 27, 2015

sounds easy enough.

@WildWeazel
Copy link
Author

no takers? guess I can knock this out tomorrow

@ProgrammerDan
Copy link

might be easier to just suppress BlockSpreadEvent for type Fire then the complex logic here?

@WildWeazel
Copy link
Author

that should work too. from or to a reinforced block, or both?

@ttk2
Copy link

ttk2 commented Aug 9, 2015

just to reinforced blocks I would say.

@suirad
Copy link

suirad commented Mar 21, 2016

So all that needs to be done here is to trim the BlockBurnEvent hook to just https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/listener/BlockListener.java#L259 and then add a hook for BlockSpreadEvent to cancel for fire if block is reinforced?

@suirad
Copy link

suirad commented Mar 21, 2016

Quoting @erocs from #119 to merge issues

Preventing reinforced block ignition might provide a much better protection against fires for such materials. The reinforcement's durability should still take a damage when cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants