Skip to content
This repository has been archived by the owner on Apr 13, 2024. It is now read-only.

driver.sh should provide less verbose output by default #217

Open
tpimh opened this issue Oct 30, 2019 · 2 comments
Open

driver.sh should provide less verbose output by default #217

tpimh opened this issue Oct 30, 2019 · 2 comments

Comments

@tpimh
Copy link
Contributor

tpimh commented Oct 30, 2019

Yeah, set -x is cool, but maybe it should be hidden behind an extra command line option (like --debug). As driver.sh gets bigger and more complicated, more output is produced and in most cases it's unnecessary unless you are debugging driver.sh itself.
I suggest only producing important information by default: versions of all utilities used, kernel version being built and a list of patches applied. Anything to add to this list?

@nathanchance
Copy link
Member

I suppose this would be okay but it is helpful to have set -x around in case people decide to use this locally and they report bugs to us. I'm fine either way though.

@nickdesaulniers
Copy link
Member

nickdesaulniers commented Nov 1, 2019

I agree that we can probably hide more things, but some parts are important to have in the output to debug when something goes wrong available in the CI logs. If you have specific sections that you think could be silenced, please call them out and let's discuss if set +x could be applied to those sections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants