-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use more residual properties when available #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename scale_sat_pure to equilibria_scale
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 321 321
Lines 24049 23993 -56
=======================================
- Hits 18485 18442 -43
+ Misses 5564 5551 -13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR:
saturation_pressure(PCSAFT("water"),373.15)
. In multicomponent equilibria, there is a problem with just equating the chemical potentials: the ideal term is of the formf(T) + log(x[i]/v[i])
and their substraction causes numerical problems. combining the two logarithms in one expression seems to stabilize the solver.p_scale
that useslb_volume
andT_scale
. fixes some scaling errors found withp_scale
methods for some EoS.EoSPhase
as a potential struct to use for representing phases (the infraestructure to use it across the methods is not yet there, probably we can use a macro to transform between our current methods return type and returning lists of phases)