Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in initial_guess.jl #339

Closed
jamiecripwell opened this issue Feb 6, 2025 · 1 comment
Closed

Typo in initial_guess.jl #339

jamiecripwell opened this issue Feb 6, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@jamiecripwell
Copy link

Hi team

I discovered what I believe is a typo in the initial_guess.jl file, line 602:

Current: vsv_ub = volume(model,psv,T,phase = :l, vol0 = v_lb)

Proposed fix: vsl_lb = volume(model,psv,T,phase = :l, vol0 = v_lb)

It raises a local variable error about vsl_lb otherwise. I discovered it by trying to refit literature parameters for ethanol using the SAFT-VR Mie model.

Thanks!
Jamie

@longemen3000 longemen3000 added the bug Something isn't working label Feb 7, 2025
@longemen3000
Copy link
Member

closed in v0.6.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants