Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 second timeout on serial port #7

Open
ellingo opened this issue Jul 22, 2023 · 0 comments
Open

5 second timeout on serial port #7

ellingo opened this issue Jul 22, 2023 · 0 comments

Comments

@ellingo
Copy link

ellingo commented Jul 22, 2023

Every command to a battery takes 5 seconds because you use readline(). Every response from a battery ends with CR, not LF. Wouldn't it be better to use read_until(b'\r') instead?

That said, I have learned a lot from your project because of its completeness. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant