-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
count(): Parameter must be an array or an object that implements Countable #262
Comments
I copied the latest version of the update manager client file into a test site, renamed it class-wc-update-client.php and made the few necessary changes to the code (edit namespace, update server and image path). I then upgraded that site from 1.1.4 to 1.2.0-rc2. No error messages appeared. |
I then manually changed the version number of CC from Version: 1.0.0-rc.2 to Version: 1.0.0-rc.1, went into the site and ran the update process. That all worked. No errors logged. |
I suggest the best course of action is to update class-wc-update-client.php to be using the latest version of the update manager client. |
Let me know if you want a PR for this. |
An issue to update Update Manager was mentioned in #211 but I was concerned it might be too much of a significant change just before v1 so it didn't go any further. With hindsight, it probably should have been done then, although I wasn't aware that it was producing errors at that time. So, yes please @simplycomputing, if you could create a PR then we'll get this into v1. Thanks. |
Details of issue
This occurs in
in classic-commerce/includes/class-wc-update-client.php
on line 662Comment on Slack:
and
The text was updated successfully, but these errors were encountered: